emesene forum
July 31, 2010, 01:19:45 PM *
Welcome, Guest. Please login or register.

Login with username, password and session length
News: CACHE KEY ERRORS? NICK NOT SAVED? UPGRADE TO 1.6.2 FIRST!

REPORT ANY ISSUE HERE - PLEASE CHECK IF THE PROBLEM HAS ALREADY BEEN REPORTED FIRST -- THANKS
 
  Home   Forum   Help Search Login Register  
Pages: 1 2 [3] 4 5 6
  Print  
Author Topic: Custom status plugin  (Read 17361 times)
Fiste788
Full Member
***

l33tness: -1
Offline Offline

Posts: 33


fiste7@aliceposta.it
View Profile Email
« Reply #30 on: February 21, 2008, 08:51:16 AM »

i find 2 bug in this plugin:
-when there are two custom status display it wrong (appear a tag "</span>" at the end)
-same problem when the custom status is in the personal message
Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #31 on: February 21, 2008, 09:57:29 AM »

i find 2 bug in this plugin:
-when there are two custom status display it wrong (appear a tag "</span>" at the end)
-same problem when the custom status is in the personal message

This isn't a bug!! You shouldn't manually put {somestatus} in any place! You should use the dialogs...!!

The problem of the span if you put {...} in personal message I think depends on emesene internal parser, and doesn't depend on the plugin, but anyway I'm going to check

I can't understand the 1st point... two custom status? ?? there should be just one!
« Last Edit: February 21, 2008, 10:08:53 AM by FMulder » Logged
Fiste788
Full Member
***

l33tness: -1
Offline Offline

Posts: 33


fiste7@aliceposta.it
View Profile Email
« Reply #32 on: February 21, 2008, 10:08:53 AM »

see the screenshot...



and a question.. it's possible too view the custom status whit same style in the tooltips of a contact too?
« Last Edit: February 21, 2008, 10:10:40 AM by Fiste788 » Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #33 on: February 21, 2008, 10:10:26 AM »

I edited the post.. read it again Smiley

But now i'm thinking I misunderstood you... you mean in status of other people right?? Huh lol sorry Smiley I'll check it
« Last Edit: February 21, 2008, 10:42:04 AM by FMulder » Logged
Fiste788
Full Member
***

l33tness: -1
Offline Offline

Posts: 33


fiste7@aliceposta.it
View Profile Email
« Reply #34 on: February 21, 2008, 10:12:35 AM »

yes.. i have a contact with 2 personal message and it display wrong
Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #35 on: February 21, 2008, 10:13:54 AM »

ok I'm checking it.. anyway it's not actually a real problem of my plugin, since your contact wrote it in the wrong way Smiley
Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #36 on: February 21, 2008, 10:36:37 AM »

FIXED!

ok Wink anyway it just fixes the wrong html code, and shows { } (like a plain message just with that kind of brackets inside) instead of recognizing the custom status, since your contact uses a wrong format for his custom status.

Just for information, the right format is a special character (\xc2\xa0 in python), followed by the opening bracket {, the status name, and the closing bracket }.
Moreover, all this stuff MUST go AT THE END of the nickname, and not in the personal message, so it's obvious that there can be just one custom status.

If you and your contacts use WLM Plus, or my plugin, for changing the status, then it is displayed in the right way. Surely your contact has changed it manually instead of using the Plus interface, and so his status is messed up Smiley

try and tell me Wink
« Last Edit: February 21, 2008, 10:41:35 AM by FMulder » Logged
Fiste788
Full Member
***

l33tness: -1
Offline Offline

Posts: 33


fiste7@aliceposta.it
View Profile Email
« Reply #37 on: February 21, 2008, 10:54:53 AM »

very good.. fixed.. thank you..
and it's possible to show the custom status gray in the tooltips too?
Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #38 on: February 21, 2008, 11:17:40 AM »

very good.. fixed.. thank you..
and it's possible to show the custom status gray in the tooltips too?

That doesn't depend on me... it's emesene internal parser that should also parse the tooltips Smiley
Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #39 on: February 22, 2008, 08:45:58 PM »

New version released

I modified the parser, now it removes the status where emesene doesn't use pango to format the nick (color, size..), for example from title bar and tooltips.

I think this is the best solution, anyway another solution could be to leave the status, replacing { } with ( ). If people prefer this other solution, I could add an option to check if you want this solution or mine.
Logged
dx
h4x0r
Administrator
Hero Member
*****

l33tness: 17
Offline Offline

Posts: 563


loldongs

dx@dxzone.com.ar
View Profile WWW Email
« Reply #40 on: March 03, 2008, 06:05:59 PM »

You'll have to clean this up a lot. For example:
- Adjust to 80 columns. Can *you* do it please?
- Spaces before and after operators, but not inside parentheses. Follow PEP 8 please.
- Docstrings in weird places. If you document the class, put it inside the class.
Code:
'''
Custom status dialog. This includes the 2 different dialogs for configuration and status set
'''
class CustomStatusDialog( gtk.Dialog ):
    ''' Custom status selector dialog '''
This particular docstring is both redundant and ugly, since is preferred to rely on the code aspect.
Code:
'''
########################### MAIN CLASSES ###############################
'''
If needed, use a short comment:
Code:
# main classes
Logged

shut up C10uD
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #41 on: March 04, 2008, 09:31:23 AM »

Cleaned the code, try to take a look... attachment on the first post.
Logged
louizatakk
Hero Member
*****

l33tness: 0
Offline Offline

Posts: 428



View Profile Email
« Reply #42 on: March 06, 2008, 10:00:52 AM »

Hello, I tried to add a Custom Avatar, to this plugin, but I'm a real noob.

Then I ask if someone can do this :
For each Custom Status, we could have a different avatar.

Would be awesome  Roll Eyes
Logged
Miles_Teg
Hero Member
*****

l33tness: 8
Offline Offline

Posts: 495


View Profile
« Reply #43 on: March 06, 2008, 11:08:55 AM »

I agree with louizatakk   Tongue
Logged
FMulder
Sr. Member
****

l33tness: 7
Offline Offline

Posts: 62


View Profile Email
« Reply #44 on: March 06, 2008, 04:14:29 PM »

If you want you can edit it as you want Smiley anyway for the moment I leave it as it is to be added to svn... then when I will have time I will improve it Smiley

dx is it ok now to be added to svn?
Logged
Pages: 1 2 [3] 4 5 6
  Print  
 
Jump to:  

TinyPortal v.1.0.6 beta 2 © Bloc
Powered by MySQL Powered by PHP Powered by SMF 1.1.11 | SMF © 2006-2009, Simple Machines LLC Valid XHTML 1.0! Valid CSS!