NoneType error in SmileyRenderer @ line 321 (def _update_smilies)

[WildDaemon]

Goodday,

I would like to inform you about the error mentioned in my title.
I did not feel like creating a TRAC ticket, as I have fixed the error myself.

The new file contains:
- a fix for the NoneType error
- an additional fix for the KeyError (that appeared after applying the previous fix)
- a space to tab conversion (as it currently saves around 3,700 bytes)
- a leading and trailing whitespace cleanup

Tested on: Windows XP SP3, Python 2.6.1 (w/ pycairo 1.4.12-2, pygobject 2.14.2-2, pygtk-2.12.1-3).

I have attached the file to this post, please keep in mind that this is saved in Windows (so it has a \r\n line ending).
This fix is tested and works. Feel free to test and modify if needed.
Thanks for your time and keep up the good work,


Greetz,

[WildDaemon]

I have looked into a way to reproduce this error and I hereby give you the answer:
Let someone on your list use one (or more) of the WLM special I'M icons (*red+u,*bgca,*hsus,*naf,*mssoc,*9mil,*sierra,*help,*komen,*unicef).


Greetz,

[Miles_Teg]

Thank you for your work, man.
I hope some dev will take care of that 

[C10uD]

applied in my own crazy branch on launchpad

note: i'm no dev or whatsoever, just collecting useful patches around in a nice launchpad branch.. 

[dx]

- a space to tab conversion (as it currently saves around 3,700 bytes)
- a leading and trailing whitespace cleanup

Never do this in a patch. We have style conventions, and they say 4 space indents.

[WildDaemon]

It does indeed say 4 spaces per indent. However, if you continue to read you'll see that the author also mentions that TABs can be used instead of spaces. It would be a wise idea to switch from spaces to TABs. Not only does it save (lots!) of bytes, in an editor like Notepad++ you can also see if there's too many leading whitespace which would lead to untidy coding. I would like to encourage you to change your 'style convention' (as you say) to TABs.

However, if you feel that I'm wrong about this then feel free to modify the file and convert all the TABs back to 4 spaces.


Greetz,

[Meithan]

I can see a discussion coming about this . Of course, it wouldn't be a half bad thing if we do it constructively. I use spaces myself, but as WildDaemon pointed out, there are some advantages to TABs. What does people think about this?