Add emoticon from URL

[Ivan!]

New diff:
ø No (?)
ø Use set_tooltip_text instead of gtk.Tooltips


Patch made with:

Code:

diff -Naur ~/Desktop/all/dialog.py ~/SVN/emesene/dialog.py > PatchEmoticonAP.diff

Code:

--- /home/ivan/Desktop/all/dialog.py 2009-10-31 16:25:33.000000000 +0100
+++ /home/ivan/SVN/emesene/dialog.py 2009-11-03 14:52:50.514637876 +0100
@@ -23,6 +23,7 @@
 import gobject
 import paths
 import Avatar
+import urllib

 import abstract.stock as stock

@@ -1112,18 +1113,35 @@
         self.shortcut = gtk.Entry()
         self.combo = gtk.combo_box_new_text()

+        tooltip_t = _("You could add an emoticon also by entering the url of a png/gif image.")
+
+        labelurl = gtk.Label(_("Or enter an image url"))
+        labelurl.set_tooltip_text(tooltip_t)
+        self.url = gtk.Entry()
+
         self.combo.append_text(CEChooser.SMALL)
         self.combo.append_text(CEChooser.BIG)
         self.combo.set_active(0)

-        hbox = gtk.HBox()
+        hbox0 = gtk.HBox()
+        hbox1 = gtk.HBox()
+        vbox1 = gtk.VBox()
+        vbox2 = gtk.VBox()
+
+        hbox1.add(self.shortcut)
+        hbox1.add(self.combo)
+
+        vbox2.add(self.url)
+        vbox2.add(hbox1)
+
+        vbox1.add(labelurl)
+        vbox1.add(label)

-        hbox.add(label)
-        hbox.add(self.shortcut)
-        hbox.add(self.combo)
+        hbox0.add(vbox1)
+        hbox0.add(vbox2)

-        self.vbox.pack_start(hbox, False)
-        hbox.show_all()
+        self.vbox.pack_start(hbox0, False)
+        hbox0.show_all()

     def _on_accept(self, button):
         '''method called when the user clicks the button'''
@@ -1131,14 +1149,24 @@
         shortcut = self.shortcut.get_text()
         size = self.combo.get_model().get_value(self.combo.get_active_iter(), 0)

-        if os.path.isfile(filename):
-            if not shortcut:
-                error(_("Empty shortcut"))
-            else:
-                self.hide()
-                self.response_cb(stock.ACCEPT, filename, shortcut, size)
+        URL = self.url.get_text()
+        ENDEXT = URL.endswith('.gif') or URL.endswith('.png')
+        if URL.startswith('http://') and ENDEXT == True:
+            NAME = URL.split('/')[-1]
+            DEST = paths.SMILIES_HOME_PATH + NAME
+            emoticonimg = urllib.urlretrieve(URL, DEST)
+            self.hide()
+            self.response_cb(stock.ACCEPT, DEST, shortcut, size)
+            os.remove(DEST)
         else:
-            error(_("No picture selected"))
+            if os.path.isfile(filename):
+                if not shortcut:
+                    error(_("Empty shortcut"))
+                else:
+                    self.hide()
+                    self.response_cb(stock.ACCEPT, filename, shortcut, size)
+            else:
+                error(_("No picture selected"))

     def _on_cancel(self, button):
         '''method called when the user clicks the button'''

With syntax highlight: http://pastebin.com/f1d587092

[C10uD]

looks fine, it will get svn soon!

[Ivan!]

looks fine, it will get svn soon!

Wonderful!

[x1sc0]

I tried it and it doesn't work properly.
When I try to add any kind of file I always get the error "Any picture selected" and the "Select a picture" window doesn't dissapear. When I try with a PNG file it dissapears but it does nothing.

[Ivan!]

You can enter only a url address starting by http:// and ending by .png or .gif.
The patch controls: 1) if in the url entry there is an url (as above). If there is an url downloads it, if no, uses the picture selected in the file selector.

Try to start emesene from terminal and paste what you get.
Does emesene show you errors?

When I try to add any kind of file I always get the error "Any picture selected" and the "Select a picture" window doesn't dissapear. When I try with a PNG file it dissapears but it does nothing.

But you are selecting a file or entering an url?

[Ivan!]

@c10ud
I made a little change.
Now check also for the url if the shortcut isn't blank.

Code:

--- /home/ivan/Desktop/all/dialog.py 2009-11-03 18:05:59.000000000 +0100
+++ /home/ivan/SVN/emesene/dialog.py 2009-11-03 19:43:25.259190187 +0100
@@ -1152,12 +1152,15 @@
         URL = self.url.get_text()
         ENDEXT = URL.endswith('.gif') or URL.endswith('.png')
         if URL.startswith('http://') and ENDEXT == True:
-            NAME = URL.split('/')[-1]
-            DEST = paths.SMILIES_HOME_PATH + NAME
-            emoticonimg = urllib.urlretrieve(URL, DEST)
-            self.hide()
-            self.response_cb(stock.ACCEPT, DEST, shortcut, size)
-            os.remove(DEST)
+            if not shortcut:
+                error(_("Empty shortcut"))
+            else:
+                NAME = URL.split('/')[-1]
+                DEST = paths.SMILIES_HOME_PATH + NAME
+                emoticonimg = urllib.urlretrieve(URL, DEST)
+                self.hide()
+                self.response_cb(stock.ACCEPT, DEST, shortcut, size)
+                os.remove(DEST)
         else:
             if os.path.isfile(filename):
                 if not shortcut:

[x1sc0]

Now it works right with a PNG file. But with other types I still get "Any picture selected". it should be replaced by "This extension is not accepted" or anything like this or even better, acept this kind of files as the pictures selector does.
bye

[x1sc0]

Small Patch to add pictures from URL which start with www as well.

[zipatei]

Error: "No Image Selected"

Url: http://upload.wikimedia.org/wikipedia/commons/4/40/Emesene-logo.png

Look:

[arielj]

Error: "No Image Selected"

Url: http://upload.wikimedia.org/wikipedia/commons/4/40/Emesene-logo.png

Look:

I was trying to fix this, but it looks like a bug with urllib (a basic python module, not an emesene's module). The image is retrieved broken from the wikipedia servers, it can't be open even with an image viewer software, so emesene can't open it either and then the error appears...

I don't know if we can fix that, maybe add a better description of the problem?...