Contacts online notifications at login (patch)

[bitzer]

This patch solves the annoying bug that cause signal "user-online" to be emitted on login for all available contacts in the contact list. The patch must be applied at the file SignalHandler.py in emesenelib directory.

[hit^]

Seems like working (?), even when I removed our delay completely from Controller.py

Anyway here's the correct patch (´svn diff´):

Code:

Index: emesenelib/SignalHandler.py
===================================================================
--- emesenelib/SignalHandler.py (revision 2061)
+++ emesenelib/SignalHandler.py (working copy)
@@ -189,7 +189,8 @@
         if oldStatus != status:
             common.debug('%s (%s) changed status from %s to %s' % \
             (nick, email, oldStatus, status), 'signal handler')
-            self.msn.emit('user-online', email, oldStatus)
+            if msnp.canNotify:
+                self.msn.emit('user-online', email, oldStatus)
             self.msn.emit('contact-status-change', email, status)
         
         contact = self.msn.contactManager.getContact( email )

[bitzer]

Ok! I hope this patch will be in svn 

[C10uD]

applied, thanks

[bitzer]

Great!

[hit^]

C10uD, isn't 20sec delay unnecessary in Controller.py now? i.e I have set it "1", instead of "20000"

[C10uD]

maybe, but i fear of what m$ could do

[nicolaide]

Nice... Now i don't have that horrible notifications!

Thanks a lot!

[nicolaide]

Is broken again or is just me!?

[bitzer]

Hmm...I don't think it's a good idea to remove the 20 seconds delay. I tried to reduce it but this made my patch useless.
Try to set it to 20 seconds again.

[hit^]

I have still set it to "1" (that is 0.001 secs) and no problems.

[DrMotte]

how apply the patch, can help me?