1.6.1 plan

[arielj]

I have used some print to debug it and for me (ubuntu) the onclick method is called every time a new conversation is opened :s if you don't believe me I can make a screencast

Oh, I see, I didn't tried it when a conversation was just created, you said that "on every message" so I tried that, opened a conversation myself and tried to send my emitocons with the conversation already opened . I'll check it and your patch

[DarKprince]

yeah, problem fixed after a ''meeting'' on emesene, since there still were some problems :-P

[arielj]

- weird utf8 plus plugin error (?)

Cloud, can you take a look into the plus plugin exception? I think it's caused for a band handled OIM...

I printed the message that's being send to the plus parser and it's something like this:

Code:

     Ï¤_]      x?      x?       «^-M         INVITE MSNMSGR:arieljprueba@hotmail.com MSNSLP/1.0
To: <msnmsgr:arieljprueba@hotmail.com>
From: <msnmsgr:arieljprueba@hotmail.com>
Via: MSNSLP/1.0/TLP ;brancho={some-hexa-code}
CSeq: 0
Call-ID: {more-hexa-code}
Max-Forwards: 0
Content-Type: application/x-msnmsgr-sessionreqbody
Content-Length: 317

AppID: 1
EUF-GUID: {hexa-code}
SesionID: a-number
Context: some-really-long-base64-code

And then a new exception gets thrown:

Code:

Exception
You are using emesene 1.6.X BETABETABETA "mate" so you're free to complain here:
http://forum.emesene.org/index.php/board,19.0.html
Check already existing tickets for duplicates first, please.
Traceback (most recent call last):

  File "D:\Downloads\Programas\Internet\Chat\MSN\emesenesvn\Controller.py", line 873, in offlineMessageReceived
    conv.receiveOIM(user['name'], message, date)

  File "D:\Downloads\Programas\Internet\Chat\MSN\emesenesvn\Conversation.py", line 365, in receiveOIM
    timestamp=time.mktime(date))

  File "D:\Downloads\Programas\Internet\Chat\MSN\emesenesvn\Conversation.py", line 700, in appendOutputText
    username, text, style, self, type, timestamp, ink, hasp4c)

  File "D:\Downloads\Programas\Internet\Chat\MSN\emesenesvn\ConversationLayoutManager.py", line 214, in layout
    result = tagRe.sub(parser.sub, self.theme[type])

UnicodeDecodeError: 'utf8' codec can't decode bytes in position 75-76: invalid data

And that's the same message that's being thrown to the parser of the plus plugin.

I can make something like "if not message.count("x-msnmsgr-sessionreqbody"): skip the message" but that's a really dirty dirty hack xD.

p.s. big thanks to arielj for pushing lots of revisions

you're welcome

EDIT: here's a link with some info of that message http://msnpiki.msnfanatic.com/index.php/MSNC:MSNSLP

EDIT2: steps to reproduce it, I had myself added to the list:
-remove myself with the "remove contact" option
-remove myself from the privacy list to complete delete me
-restart emesene
-add myself
-accept myself on the dialog to accept invitations
-wait a little time...

[cando]

with that diff there is a partial personal picture roaming: we can retrieve  our picture from msn servers but not store it.
So if we change our picture with an official client when we reuse emesene we'll have the new picture...
i'll try to resolve the "store" problem...however that is something...right?

[arielj]

with that diff there is a partial personal picture roaming: we can retrieve  our picture from msn servers but not store it.
So if we change our picture with an official client when we reuse emesene we'll have the new picture...
i'll try to resolve the "store" problem...however that is something...right?

"/tmp/" doesn't exists on windows, you should use the %TEMP% environment variable at least for windows (i don't know if it's also on linux), tempfolder = os.environ['TEMP'], something like that.

EDIT: try doing this:

Code:

        if os.name == "nt":
            tempfolder = os.environ['TEMP'] + "image"
        else:
            tempfolder = '/temp/image'
        f = open(tempfolder, 'wb')
        f.write(data)
        f.close()
        self.emit('self-dp-changed', tempfolder)

worked here on windows

EDIT2: the problem is that without storing the image on the server, we won't be able to change the picture using emesene in a permanent way... if we change it and restart emesene we will need to change it again and again (something like the old nick problem )

[C10uD]

@cando: as i wrote in the ml, that partial implementation isn't working as it should, so it must stay disabled till someone finds a way to store the dp

@arielj: i'll try to reproduce those steps

[cando]

sorry c10ud i hadn't seen you message in ml...however i'll try to fix the store problem..

[cando]

fixed picture roaming...but for now it works only from emesene to emesene....and from official client to emesene...not from emesene to official...maybe that microsoft has changed something in the protocol(also nick and personal message roaming don't work)...

other problem that i'm fixing: how to compare the picture that i take from the msn server with my avatar cache?
If i don't compare that, emesene stores the same picture everytime as a different avatar.
i can save the picture taken from server in a gtk.gdkPixbuf and then compare the pixels array of that pixbuf with the pixel arrays of every avatar in my cache.....better ways??

[hit^]

If i don't compare that, emesene stores the same picture everytime as a different avatar.

Actually this is what WLM does too, not to mention that the roaming one will be with much worse quality..

[cando]

so i could only control that the image taken from msn servera it's not the actual avatar...it simplier...what do you think???

[andreskru]

When I send a file, the tray icon start to blink... its a bug?

[cando]

Done...implemented picture roaming!! here't the diff...but for now it works only from emesene to emesene, and from official client to emesene (i don't know why but it works also from emesene to official client only the first time we install the official client...the second time onwards, the official client seems to not update the display picture nor the nick and nor the personal message.
However here it works great from emesene to emesene.Test it!
 

[C10uD]

wow, congrats! anyway that tmp stuff is bad, i used that because i wanted to quick hack it..we should use emesene cache, or something like that.. :s

[cando]

yes...you're right....but now i can't do this thing...i'm a bit busy...maybe you or arielj or anybody else could do it (would you put this in 1.6.1...?)
another question:the problem with the official client is due to a change in the protocol in your opinion?
last:there are other unofficial client that supports full content roaming???or we are the first???amsn don't,pidgin neither...i'm right?

EDIT:i've found a small bug...corrected....i've posted the new diff..

[C10uD]

amsn is the only one