Current Song Plugin Reloaded

[karasu]

Hi!

I've tried to patch the current song plugin to be able to:

1. Autodetect player:

http://forum.emesene.org/index.php/topic,2978.0.html

2. When we deactivate the plugin, be able to return to the previous avatar image:

http://forum.emesene.org/index.php/topic,2996.msg21015.htm

As I changed some "important" things of the plugin, I also noticed some little mistakes in some "subplugins". To sum it up (just in case somebody wants to code another "subplugin"):

IsRunning should tell if player is running (seems obvious, but...)

getStatus should tell if the player module can be loaded (doesn't matter if player is running or not, simply must tell if player could run and we would be able to comunicate with it). In D-Bus subplugins this function must not be overriden (as it's explained in plugins_base/currentsong/currentsong.py)

Now the changes:

- plugins_base/CurrentSong.py:
  * Changed how stored the avatar, as it always stored the last one that "worked". Now it stores only the one that we were using before loading the plugin. With the media button we load/unload it. Try it!
  * Added debug messages
  * Added "autodetect" option. LastFM subplugin can't be autodetected, as it's web based always gives us an ok.

- plugins_base/currentSong/CurrentSong.py:
  * Added isRunning function that can be used by all D-Bus based subplugins.

- plugins_base/currentSong/QuodLibet.py:
  * This subplugin returned False in getStatus when the player wasn't running. Fixed.

- plugins_base/currentSong/Amarok2.py:
  * isPlaying function didn't check if D-Bus was available or not. Fixed.
  * This subplugin returned False in getStatus when the player wasn't running. Fixed.

- plugins_base/currentSong/Spotify.py:
  * This plugin was wrongly based in CurrentSong.DbusBase when it does not use D-Bus. Fixed
  * There was no isRunning function. Written a new one.

- plugins_base/currentSong/Banshee.py:
  * Something strange here. When plugin couldn't load the song info from the player it used a info variable, that was undeclared. I simply deleted it and emptied the song info.

- plugins_base/currentSong/Xmms2.py: (this bug is mine )
  * Don't try to connect with music server if we're already connected (yes, I know...)

- plugins_base/currentSong/Audacious.py:
  * Changed audtool name to audtool2 (newer version).
  * Added isRunning function
  * Fixed getStatus function (audacious can comunicate through D-Bus or the audtool2 program)
  * Fixed a small identation mistake (nobody noticed?  )

- plugins_base/currentSong/Mpd.py:
  * Added isRunning function

In some files I added _() to be able to translate some strings (even when they are only debug messages, it's nice to show them in one's language   )

That's all folks! Diffs are against svn version 2264.

I'd like your feedback!!! Sure there are some bugs here and there...  
 

[C10uD]

:O oh shi-


i think i'll have to add this to svn :O

[karasu]

Thanks!  

I haven't tested it with ALL players, so I expect some bugs... but I'll be glad to fix them!

EDITED:

I knew it... just it gets to svn that I find a bug (not really nasty but annoying)

Steps:
 - You change your avatar with the avatar selector while the currentsong plugin is activated.
 - You get out emesene
 - You start again emesene
 - Old avatar is used

That's because current song plugin restores the old avatar when it gets out.

Anyway I think this behaviour is still better than the old one, that you always got a different avatar depending on when you got out of emesene.

Current song plugin restores to the SAME avatar that was used when the plugin was loaded.

Problem is that I don't know how to differentiate when the avatar is changed by the user from when the avatar is changed by the plugin.... I'll think about it!

[karasu]

Fixed!  

Now it seems to work... you can change your avatar while the plugin is running... it will store it, and the cover avatar never stays.

C10ud, IMHO this little fix really should be svn'up...  

Thaaaaanks!!!

[C10uD]

thank you

[Kreuger]

Can I please have the .py source so I can just stick it in my plugins dir? I dont wanna recompile

[karasu]

If you don't know how to use subversion you can browse source code here:

http://emesene.svn.sourceforge.net/viewvc/emesene/trunk/emesene/

[Kreuger]

I do know how, I just dont know how to patch the diff without rebuilding the code (if thats possible).

[karasu]

Are you using linux or windows? because if you're using windows I'm not sure how to help... You could try to simply copy the modified py files to the current_song directory. Get them from the address I've given you before.

If you can't manage send me a PM, better than filling this thread with this

[Kreuger]

Linux. I s'pose I'll just rebuild the source. Its probably the best way to go

Edit: I've downloaded the svn and ran it without compiling but didn't see an option for automatic detection in the gui. I also tried changing between players and it didn't work.

[rOckan]

Would be awesome something for the app of Grooveshark in adobe air 

[karasu]

@Kreguer: You must go to the plugins dialog and configure the current song plugin. There you MUST have an autodetect option (if you're really using latest svn version it must be there).

@rOckan: I didn't even know what Grooveshark is. It seems it may be similar to lastFM.... don't know if this can be done. It depends if Grooveshark shares its current song info. When I have some free time I'll look into it, but as always I don't promise anything! (why don't you give it a try? ).

[arielj]

@krueger, you have to choose the Autodetect "player" on the list of available players.

[Kreuger]

I got it

[karasu]

Perfect! Can I assume it works for you?